This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Bugfix: Date-filter should support high-precision date-times #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s generated by some JSON serializers
|
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): For corporations (print, sign and scan+email, fax or mail): |
|
Just signed your CLA :) |
|
Are there any updates on getting this pull request merged? We're experiencing the same problem, would love to have this fix merged into master |
|
merged to NEXT |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We're using angular.js in a .net project, leveraging json.net as our server-side json serializer. This library outputs datetimes with more than three digits of precision in the millisecond part, and these strings are not recognized by the date filter. The enclosed fix (with test) updates the regular expression for ISO format dates to recognize 1-* rather than exactly 3 digits for milliseconds (according to wikipedia, "There is no limit on the number of decimal places for the decimal fraction"; I won't cash out $105 to check with the standard myself ;-)).
As always, let us know if we can improve this patch and resubmit.
All the best,
Stein Jakob Nordbø